Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds multi-instance request distribution for the Cloudflare Worker (lazy container scaling) and exposes the handling container’s instance identifier via the API health endpoints to support load testing/diagnostics.
Changes:
- Update the Cloudflare Worker to route requests across multiple container instances using
getRandom(..., INSTANCE_COUNT). - Change the Worker cron trigger behavior from container pre-warming to a lightweight heartbeat log.
- Add
instanceIdto/healthand/api/healthresponses usingCLOUDFLARE_DURABLE_OBJECT_ID(fallback:"local").
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/DualMind.API/Controllers/HealthController.cs | Adds instanceId to health responses for identifying the serving container instance. |
| cf-worker/src/index.js | Switches to randomized multi-instance routing and adjusts cron behavior to a heartbeat. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+87
to
+88
| async fetch(request, env, ctx) { | ||
| const container = getContainer(env.DUALMIND_CONTAINER, "default"); | ||
| const container = getRandom(env.DUALMIND_CONTAINER, INSTANCE_COUNT); |
Comment on lines
4
to
7
| * This Worker orchestrates the DualMind ASP.NET Core container: | ||
| * - Routes all HTTP requests to the container | ||
| * - Keeps the container warm via cron trigger (every 5 min) | ||
| * - Routes all HTTP requests across multiple container instances (getRandom) | ||
| * - Keeps ALL instances warm via cron trigger (every 5 min) | ||
| * - Auto-sets Telegram webhook URL on deploy |
… instance selector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.