Dark/light mode - #248
Conversation
… changed all styles to dark because its more pleasing for my eyes.
…dark/light mode in core.js Changed strolestyle color for drawing crosshair back to original in stick-renderer.js. clearing canvas now resets it to the correct theme colors in calib-range-modal.js.
|
Hi, thank you for the PR, I will have a look at it asap! |
|
Chroma Pearl Chroma Indigo White Midnight Black Volcanic Red Spider-Man 2 |
|
Hi, I did a first review, and it's looking quite good! That said, the PR itself is quite large, which makes it harder to review and maintain. I'd remove the different colors for each controller from this PR. I think it's a great idea, but it could be introduced in a separate PR. It also adds extra effort whenever a new controller (and its color) is added. Thank you! EDIT: Just added a CONTRIBUTING.md with guidelines on how to contribute. |
|
Hi, i force pushed the latest commit regarding dark/light mode! I will create a new PR after this one is merged :) |
Updating to version 2.28
2 participants
Hi,
Implemented a dark/light toggle switch for changing theme's. Dark is more easier on the eyes on a big screen :). Besides that i've converted default css files to sass and also added the gulp-sass plugin in order to build the css files. This was needed for the dark/light mode.
Light Mode
Dark Mode
