Added strip shell script to xCode project in the post build process#1
Open
borntocompile wants to merge 2 commits into
Open
Added strip shell script to xCode project in the post build process#1borntocompile wants to merge 2 commits into
borntocompile wants to merge 2 commits into
Conversation
borntocompile
requested review from
FancySensei,
SlaveykoSlaveykov-Dubit,
danhalldubit,
kkjamie,
pmead and
zieglerkevin
pmead
reviewed
Dec 2, 2019
| // Add linker flags | ||
| proj.AddBuildProperty(projectTarget, "OTHER_LDFLAGS", "-ObjC"); | ||
|
|
||
| #if UNITY_2018_3_OR_NEWER |
There was a problem hiding this comment.
@HarryHodgson What is being executed here that's Unity 2018.3 specific? Is it the calls to PBXProject?
In any case, can you add a comment to show why the directive is here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the manual step for striping the unnecessary simulator architectures to the post build process. This allows for automated build pipelines such as Unity Cloud Services, but also reduces the steps require through manual builds too.
Before these changes, Unity Cloud build will fail with:
After these changes, Unity Cloud build will succeed with: