perf: NUL-string pool for Open/Query/Prepare (3/4)#85
Open
adubovikov wants to merge 3 commits into
Open
Conversation
2 tasks
Use duckdb_bind_varchar_length, direct slice pointers for blobs and UTF-8 checks, duckdb_create_varchar_length, and vector assign length APIs. Add micro-benchmarks and TestCreateVarcharEmpty.
Add withNULString/withNULStringVoid backed by sync.Pool and route high-frequency path and SQL strings (open, query, prepare, extract, config, errors) through it. Add Prepare/Query micro-benchmarks.
adubovikov
force-pushed
the
perf/upstream-pr/3-nul-pool-core
branch
from
6d28bfa to
dc7c2df
Compare
…nul-pool-core # Conflicts: # bindings.go # bindings_alloc_bench_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 3 of 4 of the split from PR #82. Adds
withNULString/withNULStringVoid(sync.Pool) and routes Open/Query/Prepare/ExtractStatements, config/error strings, etc.PR #83 is merged; this branch has been rebased onto
upstream/main. The hot-path part — PR #84 — is still open, so the diff vsmainremains cumulative (hot-path + NUL-pool); will rebase again once #84 lands to leave only the NUL-pool changes.Test plan
CGO_ENABLED=1 go test ./...CGO_ENABLED=1 go test -tags duckdb_arrow ./...