feat(appender): AppendBytes for opt-in zero-copy VARCHAR/JSON#138
Open
adubovikov wants to merge 2 commits into
Open
feat(appender): AppendBytes for opt-in zero-copy VARCHAR/JSON#138adubovikov wants to merge 2 commits into
adubovikov wants to merge 2 commits into
Conversation
2 tasks
Plain []byte in AppendRow keeps VectorAssignStringElementLen (C.CBytes copy). AppendBytes / AppendBytesUnsafe opt into VectorAssignByteElement when available in duckdb-go-bindings (requires duckdb/duckdb-go-bindings#84). json.RawMessage in setJSON maps to AppendBytesUnsafe.
adubovikov
changed the title
adubovikov
force-pushed
the
homer/append-bytes
branch
from
b90fc1e to
b7cf11c
Compare
Author
|
any one can review it or nobody interest on any PR ? |
Member
|
@adubovikov - this depends on changes in the bindings package, no? So we can come back to it once the changes are merged/discussed there. |
taniabogatsch
added
feature / enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds opt-in types for Appender columns without changing plain
[]bytebehavior inAppendRow:AppendRow[]byte/stringVectorAssignStringElementLen(C.CBytes)AppendBytesVectorAssignByteElement)AppendBytesUnsafejson.RawMessage(JSON columns)AppendBytesUnsafeDependencies
Requires duckdb/duckdb-go-bindings#84 (
VectorAssignByteElement, fixedUnsafeVectorAssignStringElementLen). Merge bindings first, then bumpgo.moddependency version if needed before merging this PR.Test plan
TestAppendBytes_varcharRoundTrip(passes once bindings Update DuckDB to v1.4.3 #84 is in the module version CI uses)