Add missing 'path' to Discount queryableMethods#175
Merged
duncanmcclean merged 1 commit intoduncanmcclean:1.xfrom Apr 20, 2026
Merged
Add missing 'path' to Discount queryableMethods#175duncanmcclean merged 1 commit intoduncanmcclean:1.xfrom
duncanmcclean merged 1 commit intoduncanmcclean:1.xfrom
Conversation
Jamesking56
force-pushed
the
fix/discount-queryable-path
branch
2 times, most recently
from
d5496bf to
dcaabfe
Compare
Jamesking56
force-pushed
the
fix/discount-queryable-path
branch
from
dcaabfe to
7cf0ca5
Compare
|
Released as part of v1.3.3. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
'path'to thequeryableMethods()array inDiscount, matchingCartandOrderFixes #174
Problem
The
Discountclass is missing'path'in itsqueryableMethods()array. This causes the stache path index to overwrite the path cache with null values duringstache:warm, becausegetQueryableValue('path')falls through to a data lookup instead of calling$this->path().After any deployment that clears and warms the stache, all discount paths become null, resulting in errors when listing discounts in the CP or applying discounts to carts.