Skip to content

Fix merchant update safety, webhook dedupe, and Soroban expiry API - #267

Merged
martinzhames merged 1 commit into
dupdab:mainfrom
JhayJ22:fix/issue-172-175-178-179
Sep 1, 2026
Merged

Fix merchant update safety, webhook dedupe, and Soroban expiry API#267
martinzhames merged 1 commit into
dupdab:mainfrom
JhayJ22:fix/issue-172-175-178-179

Conversation

@JhayJ22

@JhayJ22 JhayJ22 commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Prevent mass-assignment in merchant updates by only copying allowlisted fields.
  • Make webhook delivery job IDs deterministic and dedupable to avoid duplicate queue jobs for the same logical event.
  • Restore the expiry-aware Soroban payment API expected by the payments service and the existing expiry tests.

Changes

  • Safe merchant update path in src/merchants/merchants.service.ts
  • Stable job ID generation in src/webhooks/webhook-delivery.service.ts and src/webhooks/webhook-delivery.processor.ts
  • Reintroduce payment expiry helpers and error contract in src/blockchain-wallet/soroban.service.ts

Closes #172
Closes #175
Closes #178
Closes #179

@drips-wave

drips-wave Bot commented Aug 29, 2026

Copy link
Copy Markdown

@JhayJ22 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@martinzhames
martinzhames merged commit faf6285 into dupdab:main Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants