Skip to content

fix: Security and documentation improvements for Soroban contracts - #1038

Closed
MJigah wants to merge 1 commit into
dupdab:mainfrom
MJigah:feature/stellar-security-fixes
Closed

fix: Security and documentation improvements for Soroban contracts#1038
MJigah wants to merge 1 commit into
dupdab:mainfrom
MJigah:feature/stellar-security-fixes

Conversation

@MJigah

@MJigah MJigah commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Resolves #1019 #1020 #1021 #1022

Summary

Changes

  • fee_calculator: Added caller parameter and settlement contract authorization check
  • payment_escrow: Added emergency_drain_xlm function following same 3-signer pattern; added missing token_address helper
  • settlement_ledger: Added PaymentEscrowContract config and validation hooks; refactored constructor to support optional escrow reference
  • admin_timelock: Added comprehensive EMERGENCY_RUNBOOK.md covering malicious changes and key rotation
  • multisig_admin: Added EMERGENCY_RUNBOOK.md for lost/compromised signer recovery
  • settlement_ledger: Added EMERGENCY_RUNBOOK.md for erroneous records and dispute resolution

…updab#1021 dupdab#1022

- dupdab#1019: Add access control to fee_calculator::calculate_fee with caller authorization
- dupdab#1020: Add emergency_drain_xlm to payment_escrow for XLM asset recovery
- dupdab#1021: Add payment_escrow contract validation to settlement_ledger::record_settlement
- dupdab#1022: Add EMERGENCY_RUNBOOK.md for admin_timelock, multisig_admin, settlement_ledger
@MJigah MJigah closed this Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fee_calculator::calculate_fee lacks any access control

2 participants