fix: Security and documentation improvements - #1039
Merged
martinzhames merged 1 commit intoSep 1, 2026
Merged
Conversation
…updab#1021 dupdab#1022 - dupdab#1019: Add access control to fee_calculator::calculate_fee with caller auth - dupdab#1020: Add emergency_drain_xlm to payment_escrow for XLM recovery - dupdab#1021: Add payment_escrow validation to settlement_ledger - dupdab#1022: Add EMERGENCY_RUNBOOK.md for admin_timelock, multisig_admin, settlement_ledger
|
@unrealtim-tech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes fee_calculator::calculate_fee lacks any access control #1019
Closes payment_escrow::emergency_drain can't recover XLM-denominated escrow funds #1020
Closes settlement_ledger::record_settlement trusts caller data with no on-chain check #1021
Closes No emergency runbook for admin_timelock, multisig_admin, or settlement_ledger #1022
fee_calculator::calculate_fee lacks any access control #1019: Access control for fee_calculator::calculate_fee
payment_escrow::emergency_drain can't recover XLM-denominated escrow funds #1020: emergency_drain_xlm for XLM asset recovery
settlement_ledger::record_settlement trusts caller data with no on-chain check #1021: Payment escrow validation in settlement_ledger
No emergency runbook for admin_timelock, multisig_admin, or settlement_ledger #1022: Emergency runbooks for admin_timelock, multisig_admin, settlement_ledger
All commits authored by unrealtim-tech