Skip to content

replace dynmodb with s3 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ereli-sevenai wants to merge 7 commits into
base: main
Choose a base branch
from
+7 −8
Open

replace dynmodb with s3 #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
967a55e
use uv
ereli-sevenai Jan 7, 2025
9d7a6e0
fail if can't install the package
ereli-sevenai Jan 7, 2025
89ec2c6
Merge branch 'duplocloud:main' into main
ereli-sevenai Feb 1, 2025
2fa51b6
Merge branch 'duplocloud:main' into main
ereli-sevenai Jul 22, 2025
3fe107a
replace dynamodb with s3
ereli-sevenai Jul 22, 2025
5d95eb2
Merge branch 'duplocloud:main' into main
ereli-sevenai Sep 17, 2025
d1459d9
Merge branch 'duplocloud:main' into main
ereli-sevenai Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,19 @@ runs:
with:
python-version: ${{ inputs.python-version }}

- name: Pip Upgrade
shell: bash
run: pip install --upgrade pip

- name: Install uv
Copy link
Copy Markdown
Collaborator

@kferrone kferrone Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this for now. If you really want it, make another PR for this and make it optional.

uses: astral-sh/setup-uv@v5

- name: Install duploctl
id: install-duploctl
shell: bash
env:
VERSION: ${{ inputs.version }}
run: |
if [[ "$VERSION" == "latest" ]]; then
pip install duplocloud-client
uv pip install duplocloud-client --system || exit 1
Copy link
Copy Markdown
Collaborator

@kferrone kferrone Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just use pip here.

else
pip install duplocloud-client==$VERSION
uv pip install duplocloud-client==$VERSION --system || exit 1
fi

- name: Duplo Version
Expand Down
4 changes: 2 additions & 2 deletions terraform-module/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ ARGS=(
)

if [ "$AWS_ENABLED" == "true" ]; then
echo "AWS enabled, setting up backend config for S3 and DynamoDB"
echo "AWS enabled, setting up backend config for S3 with lockfile"
ARGS+=(
-backend-config=dynamodb_table="${PREFIX}-${DUPLO_ACCOUNT_ID}-lock"
-backend-config=use_lockfile=true
Copy link
Copy Markdown
Collaborator

@kferrone kferrone Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part I am ok with. This is the important part.

-backend-config=region=$DUPLO_DEFAULT_REGION
-backend-config=bucket=$DUPLO_TF_BUCKET
)
Expand Down