fix: reorder ssm_param create args so apply passes body correctly#246
Merged
fix: reorder ssm_param create args so apply passes body correctly#246
Conversation
Contributor
|
Task linked: DUPLO-41897 Param: apply & wait fails |
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Contributor
|
Can we call this without YAML? Have we tested such use case if it exists? |
duplodavid
approved these changes
Apr 9, 2026
kferrone
requested changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Changes
DuploResourceV3.apply()callsself.create(body)positionally, butDuploParam.createhadnameas its first parameter. This caused the YAML dict to land innameinstead ofbody, makingssm_param apply -ffail with "name and parameter value are required when body is not provided".Reordered
create(self, body, name, ...)sobodycomes first, matching the base class contract. CLI callers are unaffected since argparse passes keyword arguments.Also populated the empty
param.yamltest data file with a minimal SSM parameter body.Link to Issues
https://app.clickup.com/t/8655600/DUPLO-41897
PR Review Checklist