Skip to content

fix: reorder ssm_param create args so apply passes body correctly#246

Merged
kferrone merged 7 commits intomainfrom
fix/ssm-param-create-arg-order
Apr 17, 2026
Merged

fix: reorder ssm_param create args so apply passes body correctly#246
kferrone merged 7 commits intomainfrom
fix/ssm-param-create-arg-order

Conversation

@amaechiabuah
Copy link
Copy Markdown
Collaborator

Describe Changes

DuploResourceV3.apply() calls self.create(body) positionally, but DuploParam.create had name as its first parameter. This caused the YAML dict to land in name instead of body, making ssm_param apply -f fail with "name and parameter value are required when body is not provided".

Reordered create(self, body, name, ...) so body comes first, matching the base class contract. CLI callers are unaffected since argparse passes keyword arguments.

Also populated the empty param.yaml test data file with a minimal SSM parameter body.

Link to Issues

https://app.clickup.com/t/8655600/DUPLO-41897

PR Review Checklist

  • Thoroughly reviewed on local machine.
  • Have you added any tests
  • Make sure to note changes in Changelog

@zafarabbas
Copy link
Copy Markdown
Contributor

Task linked: DUPLO-41897 Param: apply & wait fails

@duploctl
Copy link
Copy Markdown
Contributor

duploctl Bot commented Mar 30, 2026

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3701 1433 39% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/duplo_resource/ssm_param.py 0% 🟢
src/duplocloud/resource.py 59% 🟢
TOTAL 29% 🟢

updated for commit: d304287 by action🐍

@amaechiabuah amaechiabuah requested a review from kferrone April 6, 2026 12:52
@Matheusbafutto
Copy link
Copy Markdown
Contributor

Can we call this without YAML? Have we tested such use case if it exists?

Comment thread src/duplo_resource/ssm_param.py Outdated
@amaechiabuah amaechiabuah requested a review from kferrone April 17, 2026 13:21
Copy link
Copy Markdown
Collaborator

@kferrone kferrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kferrone kferrone merged commit ce4fe94 into main Apr 17, 2026
7 checks passed
@kferrone kferrone deleted the fix/ssm-param-create-arg-order branch April 17, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants