docs(asg,ecs): fix incorrect CLI examples and add missing Usage blocks#258
Merged
duplodavid merged 1 commit intomainfrom Apr 23, 2026
Merged
docs(asg,ecs): fix incorrect CLI examples and add missing Usage blocks#258duplodavid merged 1 commit intomainfrom
duplodavid merged 1 commit intomainfrom
Conversation
Contributor
|
Task linked: DUPLO-32937 ECS Service- Documentation gaps |
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
duplodavid
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Changes
Resource-specific docstring fixes for the
asgandecsresources. Scope deliberately excludes the shared template-mechanism issue (where inherited V2/V3 docstrings render the wrong CLI name for some resources) — that's a follow-up PR.asg
createdocstring showedduploctl hosts create— corrected toduploctl asg create.scaledocstring advertised a non-existent-n <name>flag (customer gotunrecognized arguments: -n). Updated to positional usage.ecs
Audited every
@Commandinecs_service.py; 8 of 14 had noUsage: CLI Usageblock. Added blocks forcreate_service,update_service,update_taskdef,delete_service,find_def,find_def_by_arn,find_service_family, andfind_task_def_family.Also caught a latent bug:
list_task_def_familyreferenced a non-existentduploctl ecs list_definitionscommand in its example. Fixed to use the actual method name.Docs-only change — no code behavior changed, so no new tests. Verified
mkdocs buildemits no new griffe warnings for the touched files, and the existing unit tests forasg/ecsstill pass.Link to Issues
PR Review Checklist