fix(ecs): validate --container-image names against task definition#260
Open
amaechiabuah wants to merge 4 commits intomainfrom
Open
fix(ecs): validate --container-image names against task definition#260amaechiabuah wants to merge 4 commits intomainfrom
amaechiabuah wants to merge 4 commits intomainfrom
Conversation
Contributor
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
duplodavid
approved these changes
Apr 22, 2026
Contributor
duplodavid
left a comment
duplodavid
left a comment
There was a problem hiding this comment.
Might want too add a unit test for the new error case, but otherwise LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Changes
Fixes DUPLO-32970.
duploctl ecs update_image --container-image <name> <image>silently registered a new (identical) task-definition revision and triggered a service rollout when<name>didn't match any container on the existing task def.update_imagenow diffs the supplied container names against the task def before mutating anything and raisesDuploError(..., 404)naming the unknown container(s) and listing the valid ones — no revision registered, no rollout.Verified live against
ecs-hc-reproon a test tenant: bad name raises cleanly with the list of valid containers; valid names still succeed.Link to Issues
https://app.clickup.com/t/8655600/DUPLO-32970
PR Review Checklist