fix(cleanup): pixel-dust threshold in pixels#89
Merged
Conversation
The data clean-up "Remove pixel-dust traces" tool now takes its size threshold in pixels (px^2) instead of physical area (um^2), matching the "pixel dust" mental model of "smaller than N pixels on its own image". findPixelDustTraces derives the physical cutoff per section from that section's magnification (threshold_px * section.mag**2), so one pixel threshold adapts to sections of different scale. Each candidate carries both its pixel area and physical area. The review dialog shows an "Area (px^2)" column (same units as the threshold) alongside "Area (um^2)" for the physical equivalent. The dialog input defaults to 10 px^2 (a stray speck of a few pixels). Tests updated to px^2 threshold semantics, including a mixed-magnification case proving the cutoff adapts per section. WHATS_NEW updated.
dustenhubbard
enabled auto-merge (squash)
July 23, 2026 20:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer decision: the pixel-dust threshold reads in pixels (px^2), matching the mental model.
Suite: 1250 passed, 5 pre-existing xfails.