fix(gui): pre-beta-5 review findings (shortcuts help, collada, shuffle, z-trace)#90
Merged
Merged
Conversation
…e, z-trace)
- shortcuts help dialog: reword the five View toggles to match the current
menu labels (Focus mode / Hide trace layer / Show all traces (ignore
hidden) / Hide image / Section blend); fix the "viwed" typo.
- collada (.dae) export: detect pycollada via importlib.util.find_spec and
disable the menu item ("(not installed)" suffix) when absent, so frozen
builds don't offer an export that can only fail; reword the runtime guard
message to cover packaged installs. Runtime guard kept as a backstop.
- shuffle autoseg colors: next_shuffle_seed accepts an optional ids iterable
and the caller passes the overlay's visible label ids (new
ZarrLayer.getPresentIds), so the "always reshuffles" guarantee applies to
what the user actually sees; falls back to the 1..63 range when unavailable.
- z-trace label casing: lowercase mid-label "z-trace(s)" in the field
Z-trace menu (edit/delete) and the menubar item.
- menubar "Toggle show Z-traces" becomes a checkable "Show z-traces" using
the (series, "checkbox") form, synced from show_ztraces at build and in
checkActions (menubar has no aboutToShow resync hook; external option
changes reflect on the next checkActions pass).
- dedup smoothtraces_act: the Object > Geometry smooth action is renamed
smoothobj_act so it no longer shadows the field Trace submenu's
smoothtraces_act on the shared widget.
- update stale "copy row text" comments to "copy trace/z-trace values";
disable the Focus mode item when nothing is selected.
- tests updated/added for the shuffle-ids fingerprint, collada label/disable
logic, and the smooth attr_name dedup.
dustenhubbard
enabled auto-merge (squash)
July 23, 2026 20:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven small fixes from the pre-release review of #76/#78/#79/#80:
Suite: 1256 passed, 5 pre-existing xfails.