Skip to content

fix(gui): pre-beta-5 review findings (shortcuts help, collada, shuffle, z-trace)#90

Merged
dustenhubbard merged 1 commit into
mainfrom
fix/beta5-review-findings
Jul 23, 2026
Merged

fix(gui): pre-beta-5 review findings (shortcuts help, collada, shuffle, z-trace)#90
dustenhubbard merged 1 commit into
mainfrom
fix/beta5-review-findings

Conversation

@dustenhubbard

Copy link
Copy Markdown
Owner

Seven small fixes from the pre-release review of #76/#78/#79/#80:

  • Shortcuts help dialog now matches the renamed View toggles (was still 'Toggle ...'; 'viwed' typo fixed).
  • Collada (.dae) export: menu item greyed with ' (not installed)' when pycollada is absent (it is never bundled in frozen builds, so the old error's pip hint was unactionable); runtime guard reworded and kept as backstop. Bundling pycollada stays a separate decision.
  • Shuffle colors now fingerprints the labels actually present in the current section slice (new ZarrLayer.getPresentIds), so a click always changes what the user sees, even with one visible label; falls back to the old range when unavailable.
  • z-trace mid-label casing unified; menubar 'Toggle show Z-traces' converted to a checkable 'Show z-traces' synced in checkActions (documented limitation: external option changes reflect on next field event).
  • smoothtraces_act attr shadowing dedup (Object > Geometry now smoothobj_act); stale 'copy row text' comments updated; Focus mode item disabled when nothing is selected instead of erroring.

Suite: 1256 passed, 5 pre-existing xfails.

…e, z-trace)

- shortcuts help dialog: reword the five View toggles to match the current
  menu labels (Focus mode / Hide trace layer / Show all traces (ignore
  hidden) / Hide image / Section blend); fix the "viwed" typo.
- collada (.dae) export: detect pycollada via importlib.util.find_spec and
  disable the menu item ("(not installed)" suffix) when absent, so frozen
  builds don't offer an export that can only fail; reword the runtime guard
  message to cover packaged installs. Runtime guard kept as a backstop.
- shuffle autoseg colors: next_shuffle_seed accepts an optional ids iterable
  and the caller passes the overlay's visible label ids (new
  ZarrLayer.getPresentIds), so the "always reshuffles" guarantee applies to
  what the user actually sees; falls back to the 1..63 range when unavailable.
- z-trace label casing: lowercase mid-label "z-trace(s)" in the field
  Z-trace menu (edit/delete) and the menubar item.
- menubar "Toggle show Z-traces" becomes a checkable "Show z-traces" using
  the (series, "checkbox") form, synced from show_ztraces at build and in
  checkActions (menubar has no aboutToShow resync hook; external option
  changes reflect on the next checkActions pass).
- dedup smoothtraces_act: the Object > Geometry smooth action is renamed
  smoothobj_act so it no longer shadows the field Trace submenu's
  smoothtraces_act on the shared widget.
- update stale "copy row text" comments to "copy trace/z-trace values";
  disable the Focus mode item when nothing is selected.
- tests updated/added for the shuffle-ids fingerprint, collada label/disable
  logic, and the smooth attr_name dedup.
@dustenhubbard
dustenhubbard enabled auto-merge (squash) July 23, 2026 20:50
@dustenhubbard
dustenhubbard merged commit 2c04cf8 into main Jul 23, 2026
1 check passed
@dustenhubbard
dustenhubbard deleted the fix/beta5-review-findings branch July 23, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant