Skip to content

PR: Fix Broken Build #344#345

Merged
asntc merged 5 commits into
mainfrom
fix-broken-build-#344
Mar 24, 2026
Merged

PR: Fix Broken Build #344#345
asntc merged 5 commits into
mainfrom
fix-broken-build-#344

Conversation

@nelsonic
Copy link
Copy Markdown
Member

@nelsonic nelsonic commented Mar 24, 2026

Basic PR to fix the broken test/build. #344 👌
Fix warnings on cli #346

@nelsonic
Copy link
Copy Markdown
Member Author

even more tests fail after updating the Elixir version:
https://github.com/dwyl/hits/actions/runs/23485771519/job/68340825276#step:7:472

image

So, going to debug on localhost for a bit. 👨‍💻 ⏳

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8b05e58) to head (971c7c7).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #345   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        12    +1     
  Lines           98       100    +2     
=========================================
+ Hits            98       100    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nelsonic nelsonic added enhancement awaiting-review T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. elixir Pull requests that update elixir code labels Mar 24, 2026
@nelsonic nelsonic requested a review from asntc March 24, 2026 15:53
@nelsonic
Copy link
Copy Markdown
Member Author

Fixed. ✅ 😥

Copy link
Copy Markdown
Member

@asntc asntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @nelsonic 👌

@asntc asntc merged commit 40be2b7 into main Mar 24, 2026
2 checks passed
@asntc asntc deleted the fix-broken-build-#344 branch March 24, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review elixir Pull requests that update elixir code enhancement T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants