Simplify front page active state check and fix performance#770
Merged
drale1 merged 1 commit intoDrale1/8.x/#768-Home-menu-item-does-not-get-active-state-on-front-page-in-Drupal-10from Feb 26, 2026
Conversation
- Move isFrontPage() call from recursive function to caller to avoid redundant service calls on each recursion level - Remove unnecessary empty string check for item path
13 tasks
drale1
merged commit 7135289
into
Drale1/8.x/#768-Home-menu-item-does-not-get-active-state-on-front-page-in-Drupal-10
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isFrontPage()call out of the recursivedxpr_theme_menu_set_active_trail()function into the caller (dxpr_theme_preprocess_menu), passing the result as a parameter. This avoids redundant service calls on every recursion level.$item_path === '') — Drupal's<front>route resolves to/viaUrl::toString(), so only/needs to be matched.Test plan