Conversation
Collaborator
Author
|
Although the original reporter confirmed that the patch applies cleanly and fixes the issue in their local environment, I have not been able to reliably reproduce the TypeError myself. Because this depends on specific configuration/upgrade paths (where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Fix is related to the Drupal.org issue https://www.drupal.org/project/dxpr_theme/issues/3570233
Solution
This PR adds simple
is_array()guards aroundtheme_get_setting('hidden_regions')andtheme_get_setting('block_design_regions')before passing their values intoarray_filter()indxpr_theme.theme.On PHP 8+,
theme_get_setting()can returnnullfor these settings on some configurations. Passingnulldirectly intoarray_filter()causes aTypeError. With the guards in place, the theme safely skips applying the related logic when the settings are not defined, and pages render without PHP fatals.Checklist