fix(rbxml): return None from get_track when track is not found#200
Open
SAY-5 wants to merge 1 commit into
Open
fix(rbxml): return None from get_track when track is not found#200SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
When the requested TrackID, Location, or index does not match any element, Track(element=None) propagates a None into ElementTree's SubElement, which raised an unclear TypeError later. Return None instead so callers can detect a missing track. Closes dylanljones#193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #193.
When the requested TrackID, Location, or index doesn't match any element,
get_trackpreviously calledTrack(element=None). TheNonethen propagated intoElementTree.SubElement, where it surfaced as the misleadingTypeError: SubElement() argument 1 must be xml.etree.ElementTree.Element, not None.This change returns
Nonefromget_trackwhen the lookup misses, matching the suggestion in the issue, and adds a regression test that exercises bothTrackIDandLocationlookups for non-existent tracks.