chore(oxfmt): format rulesync.jsonc and disable trailing commas for JSON/JSONC#1549
Merged
dyoshikawa merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
…SON/JSONC Remove rulesync.jsonc from ignorePatterns so it's covered by oxfmt, and add an overrides entry for **/*.json and **/*.jsonc that sets trailingComma to "none" since trailing commas are not valid JSON. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates oxfmt configuration to ensure JSON/JSONC files are formatted without trailing commas, and applies that formatting to rulesync.jsonc.
Changes:
- Removes
rulesync.jsoncfrom.oxfmtrc.jsonignorePatternsso it’s formatted byoxfmt. - Adds an
overridesrule for**/*.jsonand**/*.jsoncsettingtrailingCommato"none". - Re-formats
rulesync.jsoncaccordingly (removes trailing commas).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
rulesync.jsonc |
Removes trailing commas to comply with the new JSON/JSONC formatting override. |
.oxfmtrc.json |
Enables formatting for rulesync.jsonc and enforces trailingComma: "none" for JSON/JSONC via overrides. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rulesync.jsoncfromignorePatternsin.oxfmtrc.jsonso it is covered by oxfmtoverridesentry targeting**/*.jsonand**/*.jsoncthat setstrailingCommato"none", since trailing commas are not valid JSONrulesync.jsonc(trailing commas removed)Test plan
pnpm cicheckpasses locally (fmt:check, oxlint, eslint, typecheck, tests, cspell, secretlint)pnpm exec oxfmt --check rulesync.jsoncreports no format issues after the change🤖 Generated with Claude Code