This repository was archived by the owner on Nov 29, 2022. It is now read-only.
Google Images integration. Fixes #111#119
Open
ebalassanian wants to merge 12 commits intodzenbot:masterfrom
stringsinc:master
Open
Google Images integration. Fixes #111#119ebalassanian wants to merge 12 commits intodzenbot:masterfrom stringsinc:master
ebalassanian wants to merge 12 commits intodzenbot:masterfrom
stringsinc:master
Conversation
If you only configure one service, the segmented search titles do not appear which causes the search bar to misplaced. Also, changed the text for empty results if there is no initial search term.
Only google images and flickr seem to work
Google only allows 10 photos per search. This code will recursively fetch more results until the total number needed to fulfill the search page are returned. Google also returns an error after 100 results are fetched so that is the hard limit on the number of images per query.
Owner
|
Thanks for this. Will review soon-ish. |
Author
|
I had a merge issue with DZNPhotoPickerController.m. I'll submit the fix momentarily. |
| UISearchBar *searchBar = _searchController.searchBar; | ||
| searchBar.placeholder = NSLocalizedString(@"Search", nil); | ||
| searchBar.text = self.navigationController.initialSearchTerm; | ||
| searchBar.scopeButtonTitles = [self segmentedControlTitles].count > 1 ? [self segmentedControlTitles] : nil; |
Owner
There was a problem hiding this comment.
I was about to say that this was fixed. Thanks for reverting to the previous implementation.
Author
|
Yes, that was my merge issue. Apologies for not catching it the first time... so if you're ok with the rest of the changes, you have the full edits now. |
On some devices (ipod touch for example) the searchbar frame is not set properly. This addresses the issue and ensures a valid frame.
|
Hi, Thank you, |
|
Hi! Any plans for merging this pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes address issues with the google service. Google only allows 10 photos per search. This code will recursively fetch more results until the total number needed to fulfill the search
page are returned. Google also returns an error after 100 results are fetched so that is the hard limit on the number of images per query. There are also a few other fixes for UI includes the searchbar when there is only one title. This code could be cleaned up a bit by having a constant that defines the maximum number of results for a given service. Currently this is hardcoded in the params for the service. Theoretically the code should work for any “underperforming” service.