Skip to content

Non-counting questions#2450

Open
jooooosef wants to merge 57 commits intoe-valuation:mainfrom
jooooosef:iss2391
Open

Non-counting questions#2450
jooooosef wants to merge 57 commits intoe-valuation:mainfrom
jooooosef:iss2391

Conversation

@jooooosef
Copy link
Copy Markdown
Collaborator

@jooooosef jooooosef commented May 26, 2025

closes #2391
fixes #2539

TODO:

  • add tests

@jooooosef jooooosef marked this pull request as draft May 26, 2025 19:35
Comment thread evap/staff/templates/staff_questionnaire_form.html Outdated
Comment thread evap/student/templates/student_vote_questionnaire_group.html Outdated
@jooooosef jooooosef marked this pull request as ready for review June 17, 2025 09:11
@jooooosef jooooosef requested a review from richardebeling June 23, 2025 18:40
Copy link
Copy Markdown
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, thanks :)

Comment thread evap/staff/templates/staff_questionnaire_form.html Outdated
Comment thread evap/evaluation/tests/test_models.py Outdated
Comment thread evap/evaluation/migrations/0149_question_counts_for_grade.py Outdated
Comment thread evap/evaluation/models.py Outdated
Comment thread evap/staff/forms.py
Comment thread evap/staff/templates/staff_questionnaire_form.html
Comment thread evap/student/templates/student_vote_questionnaire_group.html
Copy link
Copy Markdown
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay some more concerns; this is not an easy issue :^)

Comment thread evap/student/forms.py Outdated
Comment thread evap/student/templates/student_vote_questionnaire_group.html
Comment thread evap/staff/forms.py Outdated
Comment thread evap/evaluation/models.py
Comment thread evap/evaluation/tests/test_models.py
Comment thread evap/staff/templates/staff_questionnaire_form.html Outdated
Comment thread evap/results/tools.py
Comment thread evap/results/tools.py
@richardebeling richardebeling removed their request for review August 4, 2025 15:27
@jooooosef jooooosef force-pushed the iss2391 branch 2 times, most recently from 3eb3935 to 3f26948 Compare August 11, 2025 20:38
@janno42 janno42 force-pushed the main branch 2 times, most recently from 73e348c to 3577b6a Compare August 12, 2025 11:21
Comment thread evap/evaluation/migrations/0155_question_counts_for_grade.py Outdated
Comment thread evap/results/tests/test_tools.py Outdated
Comment thread evap/evaluation/tests/test_models.py
Comment thread evap/staff/forms.py Outdated
Comment thread evap/results/tools.py
Comment thread evap/staff/templates/staff_questionnaire_form.html Outdated
Comment thread evap/staff/templates/staff_questionnaire_form.html Outdated
Comment thread evap/staff/templates/staff_questionnaire_form.html Outdated
Comment thread evap/staff/templates/staff_questionnaire_form.html Outdated
Comment thread evap/staff/templates/staff_questionnaire_form.html Outdated
Comment thread evap/staff/forms.py Outdated
Comment thread evap/results/tests/test_tools.py Outdated
Comment thread evap/results/tools.py Outdated
Comment thread evap/staff/tests/test_forms.py Outdated
Comment thread evap/static/ts/src/staff-questionnaire-form.ts Outdated
Comment thread evap/static/ts/src/staff-questionnaire-form.ts Outdated
Comment thread evap/static/ts/src/staff-questionnaire-form.ts Outdated
Comment thread evap/static/ts/src/staff-questionnaire-form.ts Outdated
Comment thread evap/static/ts/src/staff-questionnaire-form.ts Outdated
Comment thread evap/static/ts/src/staff-questionnaire-form.ts Outdated
Comment thread evap/staff/templates/staff_questionnaire_form.html Outdated
@jooooosef jooooosef force-pushed the iss2391 branch 2 times, most recently from 77f11b9 to d360f52 Compare November 24, 2025 22:33
@jooooosef jooooosef requested a review from janno42 December 1, 2025 16:40
Comment thread evap/static/ts/src/staff-questionnaire-form.ts Outdated
Comment thread evap/static/ts/src/staff-questionnaire-form.ts Outdated
@niklasmohrin
Copy link
Copy Markdown
Member

@jooooosef We now merged #2513 which gives some conflicts, but I don't think it will be too bad. After that, I think we are mostly ready to merge this one here too

Copy link
Copy Markdown
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When opening the edit page of a questionnaire that cannot be edited, all fields except the checkboxes are disabled. The checkboxes should be disabled as well.

Comment thread evap/static/ts/src/staff-questionnaire-form.ts
@Kakadus
Copy link
Copy Markdown
Collaborator

Kakadus commented Apr 13, 2026

@jooooosef We now merged #2513 which gives some conflicts, but I don't think it will be too bad. After that, I think we are mostly ready to merge this one here too

If there are questions, I'm here to help :)

@niklasmohrin niklasmohrin removed their request for review April 13, 2026 22:33
@niklasmohrin
Copy link
Copy Markdown
Member

niklasmohrin commented Apr 13, 2026

(please re-request once conflicts are resolved)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Non-counting questions Cannot change question type and allows_additional_textanswers of text/heading questions simultaneously

5 participants