Skip to content

Minor preparations for question/questionnaire split#2535

Merged
janno42 merged 4 commits intoe-valuation:mainfrom
Kakadus:various
Oct 25, 2025
Merged

Minor preparations for question/questionnaire split#2535
janno42 merged 4 commits intoe-valuation:mainfrom
Kakadus:various

Conversation

@Kakadus
Copy link
Copy Markdown
Collaborator

@Kakadus Kakadus commented Oct 22, 2025

extracted some independent changes from #2513 for easier reviewability

  1. pylint rule is covered in ruff and needed for out-of-line imports in temporary tool
  2. question types helped me a lot to avoid question <-> questionassignment confusions
  3. unrelated typo fix
  4. fixed odd questionnaire type handling in text answer exporter (+ added type assertion) found while tracing question usage

@Kakadus Kakadus requested a review from niklasmohrin October 22, 2025 16:28
@Kakadus Kakadus changed the title Question type extract independent question changes from #2513 Oct 22, 2025
Copy link
Copy Markdown
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@niklasmohrin
Copy link
Copy Markdown
Member

niklasmohrin commented Oct 22, 2025

Do you mind changing the title to something like "Minor preparations for question/questionnaire split", or anything else that summarizes the content instead of the act of creating the PR? I was slightly confused about what "independent questions" are when I saw the github notification :D

@Kakadus Kakadus changed the title extract independent question changes from #2513 Minor preparations for question/questionnaire split Oct 22, 2025
@janno42 janno42 merged commit 0519fcc into e-valuation:main Oct 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants