Run QuestionAssignment's delete garbage collection in signal#2675
Merged
niklasmohrin merged 2 commits intoe-valuation:mainfrom Mar 16, 2026
Merged
Run QuestionAssignment's delete garbage collection in signal#2675niklasmohrin merged 2 commits intoe-valuation:mainfrom
niklasmohrin merged 2 commits intoe-valuation:mainfrom
Conversation
The model's `.delete` method is not called when an object is deleted from a queryset or in a cascading delete. Instead, the `post_delete` signal can be used. See https://docs.djangoproject.com/en/6.0/topics/db/models/#overriding-model-methods
niklasmohrin
requested review from
Kakadus and
richardebeling
and removed request for
Kakadus
Kakadus
approved these changes
Mar 16, 2026
Collaborator
Kakadus
left a comment
Kakadus
left a comment
There was a problem hiding this comment.
Makes sense and reduces complexity in the delete handler.
Member
|
We're also hoping that it may fix #2674 (which has happened again today) |
richardebeling
approved these changes
Mar 16, 2026
| @transaction.atomic | ||
| def _question_assignment_post_delete(*, instance: QuestionAssignment, **_kwargs) -> None: | ||
| """Garbage-collect unused questions once no questionnaires reference them anymore.""" | ||
|
|
Member
There was a problem hiding this comment.
For the record: Based on the current django source code, we expect this signal to fire within a transaction that deletes the "parent" object. So, a failure in the handler should also undo the deletion of the object that sent the signal (which is probably good for us)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The model's
.deletemethod is not called when an object is deleted from a queryset or in a cascading delete. Instead, thepost_deletesignal can be used. I also made sure to wrap the handler in a transaction to rule out this kind of error.See https://docs.djangoproject.com/en/6.0/topics/db/models/#overriding-model-methods and #2513 (comment)
TestQuestionnaireandQuestionnaireTests, and downgrade to TestCase