Moar types#2687
Open
richardebeling wants to merge 5 commits intoe-valuation:mainfrom
Open
Conversation
niklasmohrin
reviewed
Apr 2, 2026
Member
niklasmohrin
left a comment
niklasmohrin
left a comment
There was a problem hiding this comment.
some more files checked off; should we maybe split this into multiple PRs so that reviewed changes can get merged before they get conflicts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because moar = better
I think we can conclude by now that python type hints are not going anywhere, so we may just as well annotate our interfaces to benefit from better LSP understanding and type checking.
Split into two commits, the first one should be very quick to review, containing only type changes. The second one contains everything that needs to touch actual production logic, mostly by adding assertions.