Add dynamic CSS "empty" disclaimer to all datagrids#2704
Add dynamic CSS "empty" disclaimer to all datagrids#2704niklasmohrin wants to merge 3 commits intoe-valuation:mainfrom
Conversation
|
Waiting for #2587 to spare them the rebase |
a9a85d5 to
7ba5a9e
Compare
|
I think we are running into a firefox bug on the questionnaire index. The first time (per tab) that I filter for something, if it matches nothing (i.e. you have to enter something like adljaladljad right away without a table update from a prefix), the disclaimer does not show up. The disclaimer shows up if:
It does work again if you remove the filter, switch to another questionnaire tab, and enter alkjhdf again. Very strange. In chromium everything works as expected |
|
Oh, I can also get it to break in other places. Semester view, enter something that doesn't match anything (evaluation or course list, doesn't matter). Reload page. Empty table, no disclaimer. Funnily enough, this is exactly the opposite of when it breaks on the questionnaire page |
|
Probably firefox is tripping up with our table contents remove and append here EvaP/evap/static/ts/src/datagrid.ts Lines 211 to 216 in 8807428 |
Interesting, I can reproduce it, but not consistently. When reloading multiple times, the notice sometimes shows and sometimes is missing. Additionally, I can not reproduce it, if I have my devtools open 🙃 ... |
|
I opened a ticket at bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=2035307 |
Closes #2662
I made two separate commits, the first has the meaningful changes and the second fixes the indentation.