Skip to content

fix: plugin name to match naming convention#81

Open
euaaaio wants to merge 3 commits intoe18e:mainfrom
euaaaio:fix/plugin-meta
Open

fix: plugin name to match naming convention#81
euaaaio wants to merge 3 commits intoe18e:mainfrom
euaaaio:fix/plugin-meta

Conversation

@euaaaio
Copy link

@euaaaio euaaaio commented Mar 16, 2026

Changes meta.name and meta.namespace properties so it follows the ESLint plugin naming convention (same approach as @typescript-eslint/eslint-plugin).

This is also necessary so that oxlint-migrate can name the package correctly.

Before: eslint-plugin-e18e
After: @e18e/eslint-plugin

43081j
43081j previously approved these changes Mar 16, 2026
@43081j
Copy link
Contributor

43081j commented Mar 16, 2026

this will break oxlint support

we are blocked until oxc-project/oxc#20440

@euaaaio
Copy link
Author

euaaaio commented Mar 16, 2026

@43081j, I just tested it, and it looks like everything works. oxlint-migrate renamed the rules from e18e/prefer-array-at to @e18e/prefer-array-at. I think that’s a logical and correct approach.

I think we can just update the documentation for oxlint. It’s ok for a major version 0 of the package.

@43081j
Copy link
Contributor

43081j commented Mar 16, 2026

that will break ESLint where the rules are e18e/{name}, not @e18e/{name}.

im pretty sure you can't fix this and oxlint needs to support namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants