fix(python): route Jupyter requests through client-proxy when E2B_SANDBOX_URL is set #196
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DBOX_URL is set When E2B_SANDBOX_URL is set (local/self-hosted environments), the base SDK correctly routes envd API requests through the client-proxy via `get_sandbox_url()`. However, the code interpreter SDK's `_jupyter_url` property constructs its own URL using `get_host()`, bypassing E2B_SANDBOX_URL entirely. This causes Jupyter requests (run_code, etc.) to be sent to the production E2B API instead of the local client-proxy, resulting in 502 errors. This fix: - Updates `_jupyter_url` to use E2B_SANDBOX_URL when available - Adds `E2b-Sandbox-Id` and `E2b-Sandbox-Port` headers for local client-proxy routing (supported in local mode) - Applies to both sync and async Sandbox classes Cloud users are unaffected as E2B_SANDBOX_URL is not set in that flow. Co-authored-by: Cursor <cursoragent@cursor.com>
hwlzc
requested review from
ValentaTomas,
jakubno and
mishushakov
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
E2B_SANDBOX_URLis set (local/self-hosted environments), the code interpreter SDK's Jupyter requests (run_code,create_code_context, etc.) bypassE2B_SANDBOX_URLand are sent directly to the hostname-based URL (e.g.https://49999-{sandbox_id}.e2b.app), which fails in local setups.e2b) correctly handles this viaget_sandbox_url(), but the code interpreter's_jupyter_urlusesget_host()directly._jupyter_urlto respectE2B_SANDBOX_URLand addsE2b-Sandbox-Id/E2b-Sandbox-Portheaders for local client-proxy routing.Sandbox) and async (AsyncSandbox) classes are fixed.E2B_SANDBOX_URLis not set in cloud flow).Test plan
run_code()works with stateful execution (variable persistence across calls)E2B_SANDBOX_URLis not set)