Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The hardcoded mount point preset-fix-mount in builder.go is shared across concurrent template builds, which can cause mount conflicts, race conditions, and data corruption; using a unique directory name per build prevents these issues.
Appending || true to package installation commands in provision.sh for RHEL and Alpine distros silently swallows failures, which can result in broken template images at runtime instead of halting the build.
Directly interpolating userArg into a shell command in user.go introduces a command injection vulnerability, which should be mitigated by validating that the username conforms to a strict alphanumeric pattern before execution.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
5aad415 to
d71980e
Compare
|
Should be solved in #3411 |
3 participants
Description
Previously custom template builds only supported Debian/Ubuntu images relying on apt package manager, and failed on Alpine, CentOS/RHEL due to distro-specific provisioning scripts.
This change extends template provisioning logic to support mainstream Linux distributions:
Debian / Ubuntu (apt)
Alpine (apk)
CentOS / RHEL (dnf/yum)
The provisioning layer auto-detects target OS distribution, switches to corresponding native package manager, and adapts distro-specific package names & system file paths automatically during template build and provisioning phase.
Changes
Add OS distro detection logic to identify base image system
Implement separate provisioning branches for apt / apk / dnf/yum package managers
Normalize package names and file paths compatible with Alpine, CentOS/RHEL
Remove limitation that restricts templates to Debian-family images
/cc @jakubno @dobrac @ValentaTomas Would appreciate your review on this change, thanks!