-
Notifications
You must be signed in to change notification settings - Fork 436
db: drop the superseded env_build_assignments tip-lookup index #3409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
35 changes: 35 additions & 0 deletions
35
packages/db/migrations/20260727060500_drop_superseded_eba_tip_index.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| -- +goose Up | ||
| -- +goose NO TRANSACTION | ||
|
|
||
| -- DROP waits on in-flight lock holders rather than building anything; bound | ||
| -- it so it neither hangs unbounded nor dies to a short session default. | ||
| SET statement_timeout = '1h'; | ||
|
|
||
| -- Follow-up to 20260727032500 (the additive half): the 4-column | ||
| -- idx_env_build_assignments_env_tag_created_build shares this index's exact | ||
| -- ordering prefix, so every scan the 3-column copy served runs identically | ||
| -- on it — keeping both only doubles write maintenance on a hot-insert | ||
| -- table. Merge only after the 4-column index has soaked in production. | ||
| DROP INDEX CONCURRENTLY IF EXISTS idx_env_build_assignments_env_tag_created; | ||
|
|
||
| -- The migrator session is reused for subsequent migrations: restore its | ||
| -- baseline (scripts/migrator.go sets 3h per connection). | ||
| SET statement_timeout = '3h'; | ||
|
|
||
| -- +goose Down | ||
| -- +goose NO TRANSACTION | ||
|
|
||
| -- The concurrent rebuild legitimately runs long at this table's size; a | ||
| -- mid-build timeout would strand an INVALID index. Rolling back is a | ||
| -- deliberate manual operation with an operator present — unbounded on | ||
| -- purpose. | ||
| SET statement_timeout = 0; | ||
|
|
||
| -- An interrupted CONCURRENTLY build leaves an INVALID index that IF NOT | ||
| -- EXISTS would then skip forever — clear any leftover before rebuilding. | ||
| DROP INDEX CONCURRENTLY IF EXISTS idx_env_build_assignments_env_tag_created; | ||
|
|
||
| CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_env_build_assignments_env_tag_created | ||
| ON public.env_build_assignments (env_id, tag, created_at DESC); | ||
|
|
||
| SET statement_timeout = '3h'; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.