Conversation
(cherry picked from commit fe3d95764)
(cherry picked from commit 141d45766)
(cherry picked from commit ac770b2c5)
Keep plaintext listener unchanged while serving TLS on an explicit address.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: uweltman, Ulf Weltman.
|
PR SummaryMedium Risk Overview gRPC: HTTP proxy: Clients can use Reviewed by Cursor Bugbot for commit db107cc. Bugbot is set up for automated code reviews on this repo. Configure here. |
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: uweltman, Ulf Weltman.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit db107cc. Configure here.
|
|
||
| creds := credentials.NewServerTLSFromCert(&cert) | ||
| serverOpts = append(serverOpts, grpc.Creds(creds)) | ||
| } |
There was a problem hiding this comment.
Incomplete TLS silently disables encryption
Medium Severity
WithTLS / WithTLSFromPEM only enable credentials when both cert and key are non-empty. If either side is missing or empty, NewGRPCServer falls through and serves plaintext with no error, so a misconfigured TLS enablement path can silently leave traffic unencrypted.
Reviewed by Cursor Bugbot for commit db107cc. Configure here.


No description provided.