fix: use GHA expression syntax for GOLANGCI_LINT_VERSION in copilot-setup-steps#24
Merged
Merged
Conversation
…etup-steps Agent-Logs-Url: https://github.com/e2b-dev/ublk-go/sessions/f515b9d7-565f-4496-962f-5319eca8b205 Co-authored-by: ValentaTomas <49156497+ValentaTomas@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
ValentaTomas
May 1, 2026 23:54
View session
2 tasks
PR #24's failing `copilot-setup-steps` runs (and the integration runs) all bottom out on the same root cause: `apt-get update` and `apt-get install` against `azure.archive.ubuntu.com` intermittently fail with `Temporary failure resolving`. This is the same flake that PR #29 (ci/apt-retry) addresses for `.github/workflows/ci.yml`. Wire the same retry helper (max 6 attempts, exponential backoff with sleeps of 5s, 10s, 20s, 40s, 80s) around both apt-get invocations in `copilot-setup-steps.yml`: - `apt-get update` + `apt-get install e2fsprogs kmod` in "Install repo tooling". - `apt-get install linux-modules-extra-$(uname -r)` in "Load ublk kernel module". The helper definition is duplicated rather than factored out — the two steps are independent shell sessions, so a single helper would have to live in a separate script or composite action. Keeping it inline matches the pattern used in `ci.yml`. This is an additive commit on top of copilot's original change; no existing commits are amended.
matthewlouisbrockman
approved these changes
May 4, 2026
ValentaTomas
added a commit
that referenced
this pull request
May 4, 2026
## Summary The Azure-hosted apt mirror (\`azure.archive.ubuntu.com\`) returns \`Temporary failure resolving\` periodically — observed today on PRs #24, #26, and #27, all blocked by the same DNS blip while installing \`linux-modules-extra\`. This PR wraps the \`apt-get update\` + install in a 5-attempt exponential backoff (5s, 10s, 20s, 40s, 80s — ~155s worst case before giving up). The fast path (\`modprobe ublk_drv\` succeeding because the module is already present in the runner image) is unchanged. No code changes; CI workflow only. ## Test plan - [ ] CI run for this branch loads ublk_drv and runs integration tests cleanly. - [ ] If the apt mirror flakes during the run, the retry should absorb it; logs will show \`attempt N failed; sleeping...\`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copilot-setup-steps.ymlused shell variable syntax${GOLANGCI_LINT_VERSION}in therun:block. Withset -eux, the-uflag errors on unbound variables — the job-levelenv:key doesn't automatically populate a shell variable by the same name.Change
Switch to GHA expression syntax, which the Actions runner expands to a literal string before the shell sees the script — the same pattern already used in
ci.yml: