fix: Chinese path encoding and session resume on Windows#3
Open
AAAAaron wants to merge 2 commits intoeLeanwang:mainfrom
Open
fix: Chinese path encoding and session resume on Windows#3AAAAaron wants to merge 2 commits intoeLeanwang:mainfrom
AAAAaron wants to merge 2 commits intoeLeanwang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for Chinese/non-ASCII project paths on Windows:
1.
encodePath()insrc/utils/cross-platform.tsReplace all non-ASCII characters with
-to match Claude Code's actual path encoding convention. Without this, a path likeD:\tx\定制绘本生成was encoded asD--tx-定制绘本生成but Claude Code creates sessions atD--tx-------.2.
validateSessionFile()insrc/core/session-manager.tsStop clearing
agent_session_idfrom the DB when the session file is not found. This allows session resume to work correctly - the ID is preserved so the SDK can attempt to locate/create the session file.3.
needsSchemaRefactorguardAdd
hasIsGroupas a required guard to prevent false-positive migration triggers on already-migrated databases (which causedno such column: deleted_aterrors on startup).Test plan
D:\tx\定制绘本生成resumes existing sessionno such columnerror~/.claude/projects/D--tx-------/path