Added Zoe #27
Merged
Added Zoe #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolfHut
requested changes
Jul 18, 2025
Contributor
RolfHut
left a comment
RolfHut
left a comment
There was a problem hiding this comment.
Images from Zoe her work do net render:
* added files for structure * Maandag * Critical inflow * changed * Shape files * Model calibration * code * Calibration * calibration ouputs * 4 april * 5 april * 5 april * 6 juni * Brugges * 9 juni * 10 june * 12 juni * 13 juni * 13 juni avond * 14 juni * 15 juni 18:00 * Depri UB avond 15 juni * 16 juni avond laaatttt * Laatstteeeee * Last Commit * Update BSc_ZoeLucius.md * added the copyrights --------- Co-authored-by: Zoe <zoe.lucius.nova@gmail.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
* Test_08_05 toegevoegd Test_08_05 toegevoegd voor testen git command * critical_days_module toegevoegd * CrititcalDaysLowFlow.ipynb toegevoegd * HBV_Calibration_Code(logNSE&EMD).ipynb toegevoegd * HBV_Calibration_Code(RMSE&EMD).ipynb toegevoegd * HBV_FR000119_logNSE&EMD.ipynb toegevoegd * HBV_FR000119_RMSE&EMD.ipynb toegevoegd * WFlow_FR000119.ipynb overgezet * 2.0_WFlow_FR000119.ipynb toegevoegd * 2.0_WFlow_FR000119_API.ipynb toegevoegd * HBV aangepast met drought analyser * WFlow naar m3/s aangepast * WFlow met m3/s maar zonder plot gauges * Droughts function aangepast, geen deficit meer * WFlow m/s met plots van gauges * Toekomst CMIP met csv file van alle data * historic CMIP run * Drought analysis toegevoegd * Future CMIP opgeschoond * future CMIP opgeschoond * laatste aanpassingen * laatste aanpassingen * laatste run * laatste run * laatste run, nieuwe par * laatste run * laatste run * laatste run * laatste run * comments aangepast * overkoepelend hoofdstuk calibratie toegevoegd * CDF formules toegevoegd, voor alle MEV distributions * Uitleg SSPs * RMSE uitgelegd * comments aangepast * toelichting waarom historic CMIP * LogNSE en EMD uitgelegd * draft conclusion, needs to be rewritten! * Abstract added * background added * intro added, figure HBV needed and reading guide * Acknowledgements added * Merge NBs added * Nomenclature added * Preface added * References added, not complete! * Naar rapport en kleuren aangepast * Naar rapport en kleuren aangepast, variabelen goed * Naar rapport en kleuren aangepast, alles in 1 nb * droughts function aangepast, moet nog checken! * Naar rapport en kleuren aangepast, variabelen RMSE goed * Naar rapport en kleuren aangepast * Naar rapport en kleuren aangepast, variabelen goed * updated drought function * aaangepast voor return period gumbel * opgeruimd * opgeruimd * nog herschrijven na nieuwe analyse! * Drought analysis, -1 * Q * Drought analysis, 1 / Q * Discharge data FR000119 * laatste aanpassing * laatste aanpassing * Drought analysis Final * per 3 jaar toegevoegd * opgeschoond * 10 & 20 jaar toegevoegd * Drought analysis_Final toegevoegd * Historic CMIP Final * Historic CMIP Final in report * Future CMIP Final to report * opgeschoond * WFlow in appendix * HBV output RMSE in appendix * HBV RMSE code in appendix * Model Calibration Final in report * poging tot splitten * poging tot splitten * poging tot splitten * ready for final feedback * score bepalen parameters * ready for final feedback --------- Co-authored-by: elke <e.f.schokking@student.tudelft.nl>
Contributor
Author
|
@RolfHut should be okay now, but need to look through both, especially Elke's |
RolfHut
requested changes
Sep 9, 2025
Contributor
RolfHut
left a comment
RolfHut
left a comment
There was a problem hiding this comment.
Small things:
both
- Background: all figures need copy right statement, so not reference, but "taken from (cite) (c). (or (cc by) or whatever the license is.
Elke:
- Introduction, last line: what is "Github Report Folder"? Needs link or remove
- HBV model: maybe hide cells with only comments?
- HBV model: under objective functions: shouldn't 1. and 2. be just lower level headers?
- HBV model: I don't see output of the cells?
Zoe:
- introduction: bullets in 1.3 don't look like markdown?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elke is on here as well, but commented out for now, to get her figures to load later on.
Zoe's is final!