small fixes for issue #32 #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
Author
|
@RolfHut ready for review! |
RolfHut
requested changes
Oct 9, 2025
Contributor
RolfHut
left a comment
RolfHut
left a comment
There was a problem hiding this comment.
The last two cells from the example_model_run_pcrglobwb notebook are not run. Is this on purpose? Either remove those cells and that part of the notebook, or have those two cells also run. Other than that I don't see any other problems.
Contributor
Author
|
@RolfHut I pushed the wrong one..., now it is all there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix issue #32.
The bit about the .ini file is still missing.
That will be fixed in the getting-started page