Skip to content

WIP: Add windups to incoming messages. - #17

Draft
judytuna wants to merge 3 commits into
earthstar-project:mainfrom
judytuna:windupify
Draft

WIP: Add windups to incoming messages.#17
judytuna wants to merge 3 commits into
earthstar-project:mainfrom
judytuna:windupify

Conversation

@judytuna

@judytuna judytuna commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

This winds up messages that are older than 5 minutes. However, the performance is terrible.

…load and windup of latest messages.) Find another way. But it does only windup messages older than 5 minutes.
@sgwilym

sgwilym commented Dec 10, 2020

Copy link
Copy Markdown
Collaborator

I think we'd only want to see this effect on the very last message. Here's how I'd go about it personally:

  • In Message, wrap the rendering of ActionisedMessage in <WindupChildren>.
  • Add a isLastMessage prop to Message
  • Make it so that if isLastMessage is true, the skipped prop on WindupChildren is true
  • Using the index of a doc when MessageList renders all the docs using docs.map, determine whether the doc being mapped over is the last one, and pass that to the new isLastMessage prop you added to Message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants