fix(ci): complete taskTree translations for all locales + mock backfillTaskDepth in single-open spec - #15
Merged
Conversation
…llTaskDepth in single-open spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ci): complete taskTree translations for all locales + mock backfillTaskDepth in single-open spec
Fixes the four failing CI jobs from the PR #10/#11 runs on
main-task-tree.1.
check-translations— 4 missing keys × 17 frontend locales (code fix)PR-11 added
contextManagement.taskTree.{maxNestingDepth,autoFlattenOnLimit}.{label,description}to the English locale but not to the other 17 (ca de es fr hi id it ja ko nl pl pt-BR ru tr vi zh-CN zh-TW). Each of thosewebview-ui/src/i18n/locales/<loc>/settings.jsonfiles now carries a genuine per-language translation of the four keys, inserted beforecondensingThresholdto match the English file's ordering.Verified:
node scripts/find-missing-translations.js --area webview→ all 17 locales "No missing translations", exit 0 (was exit 1 with 4 missing keys per locale).2.
platform-unit-test (ubuntu)— spec mock missingbackfillTaskDepth(code fix)PR-10 added
if (!task.depthAuthoritative) await this.backfillTaskDepth(task)tocreateTaskWithHistoryItem. The two "History resume path" tests insingle-open-invariant.spec.tsbuild plain-object provider doubles that lacked the method, and their mockedTaskStubhas nodepthAuthoritative(undefined → falsy → enters the backfill branch) — so the call threw. AddedbackfillTaskDepth: vi.fn().mockResolvedValue(undefined)to both provider mocks (the non-rehydrating case at ~L168 and the rehydrating/in-place case at ~L267), matching how every other method on those doubles is stubbed.Verified:
vitest run __tests__/single-open-invariant.spec.ts→ 5/5 pass (was 3 passed / 2 failed).3.
dependency-review— repo setting, not code (no workflow change)The job failed with "Dependency review is not supported on this repository" because the fork had Dependency graph disabled. Enabled it via API (
PUT repos/easonLiangWorldedtech/Zoo-Code/vulnerability-alerts, now returns 204 instead of 404). Thedependency-reviewjob in.github/workflows/code-qa.ymlis left untouched — it will run normally on the next PR. No code change needed for this item.4.
platform-unit-test (windows)— cancelled, not a failureCancelled ~4s after the ubuntu unit-test job failed (CI cancel-on-failure behavior). Re-running CI with the spec fix above resolves it; no separate change.
Verification
vitest run __tests__/single-open-invariant.spec.ts→ 5/5node scripts/find-missing-translations.js --area webview→ exit 0, all locales clean--max-warnings=0) → clean; pre-commit full turbo lint (zoo-code + webview-ui) → Tasks: 11 successfulcontextManagement.taskTreepresent