Conversation
Introduces bench/ for capturing baselines before/after future refactors. Three layers, no src/ changes: * Bundle size — walks dist/ for raw + gzipped totals. * Lighthouse CI — runs the demo via vite preview against three UniProt scenarios (P05067, P38398, A0A2K5ULD0); 5 runs per URL, median reported. * Custom milestones — bench/instrument.js (loaded only on ?bench=1) uses MutationObserver on the host to mark fetch-and-parse, render, and total. Lighthouse captures these via its user-timings audit. Adds @lhci/cli devDep.
… so bench baselines survive refactors.
Swaathik
approved these changes
Apr 29, 2026
…arks Performance baseline marks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses:
Performance: define baseline metrics and profiling workflow #100
Adds bench/ for repeatable performance baselines. Three layers, no src/ changes:
Adds @lhci/cli devDep.
Purpose
Repeatable, documented perf measurement so the upcoming config refactor can be evaluated against a stored baseline. Satisfies the perf-baseline issue's acceptance criteria.
Approach
yarn benchruns all three layers and writesbench/results/summary.md. Reference snapshots are committed underbench/baselines/; per-run output is gitignored.Custom marks observe DOM transitions on the host (loader removed → data loaded; nightingale-manager present → first render; 250 ms of subtree quiescence → tracks settled).
Testing
yarn benchend-to-end; values stable, scenarios differentiate as expected (fetch-and-parse scales with payload; TBT catches canvas-paint cost the observer can't see).node --checkon all scripts; smoke-testedsummarize.mjsagainst a synthetic LH report.bench/baselines/summary-pre-config-<sha>.md.Visual changes
None. Demo renders identically without
?bench=1.Checklist