cd(backstage): frontend dd74672 — keycloak sign-in in app plugin, restore notifications/search/scaffolder - #16
Merged
Conversation
…tore notifications/search/scaffolder
- values.yaml: image tag 53692a6 -> dd74672e8282cc8e641ad7831135dba6418b6fe2
- appset-helm.yaml: backstage valueURL ?v=15 -> ?v=16
Fixes two frontend regressions:
1. Startup crash: NotificationsSidebarItem calls useApi(notificationsApiRef)
at render; the ref is only implemented by the notifications plugin, which was
missing from features. Added notifications/search/scaffolder plugins.
2. Keycloak "Sign in" button gone: app/root signInPage input is {internal:true},
so only app-plugin extensions attach; the keycloak page was in a separate
plugin and was ignored -> guest-only DefaultSignInPage. The SignInPageBlueprint
now lives in createFrontendModule({pluginId:"app"}) and replaces the default.
There was a problem hiding this comment.
🔵 Needs a closer look
The rebuilt frontend bundle requires final human validation despite no blocking review comments.
Pull request overview
Updates Backstage to a frontend image containing Keycloak sign-in and plugin fixes.
Changes:
- Bumps the Backstage image to
dd74672e. - Updates the ArgoCD values cache-buster to
v=16.
File summaries
| File | Description |
|---|---|
helm/releases/backstage/values.yaml |
Updates the Backstage image tag. |
bootstrap/appset-helm.yaml |
Forces ArgoCD to reload updated Helm values. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the Backstage frontend image to the newly built
dd74672(Woodpecker #11 success, bundlemain.faae978834be.js).helm/releases/backstage/values.yaml: image tag53692a6…→dd74672e8282cc8e641ad7831135dba6418b6fe2bootstrap/appset-helm.yaml: backstage valueURL?v=15→?v=16Why — fixes two frontend regressions
NotificationsSidebarItemcallsuseApi(notificationsApiRef)at render; the ref is only implemented by the notifications plugin, which was missing fromfeatures. Addednotifications/search/scaffolderplugins.app/rootsignInPageinput is{internal:true}, so only app-plugin extensions attach. The keycloak page was in a separate plugin → ignored → guest-onlyDefaultSignInPage. TheSignInPageBlueprintnow lives increateFrontendModule({pluginId:"app"})and replaces the default;keycloakAuthApi(auth.keycloak) registered viacreateFrontendPluginapis.Verification
Woodpecker build #11 (clone+build) success. Served-bundle + backend curl verification to follow after rollout.