Add failing tests for Model.find() not returning sideloaded data #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@jnovatnack want to take a stab at this? :) |
Contributor
|
Funny enough I noticed this yesterday as well. |
Owner
|
@jnovatnack you got this? |
Contributor
|
Sure, I'll take a shot at it. On Mon, Mar 10, 2014 at 5:24 PM, Erik Bryn notifications@github.com wrote:
|
Owner
|
@jnovatnack ping ;) |
Contributor
|
Dug into this a bit. Are we sure that if you sideload data with load() then find() should not execute a remote request and only return the side loaded data? The second test case makes sense to me though since find([single-id]) already returns the sideloaded data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing tests for #314, #247
When sideloading data and subsequently calling find() or find([array of ids]), ember-model will call through to the adapter and try to retrieve data from the server, instead of materializing and returning the sideloaded data instantly.