Uses the method from ajaxSettings instead of passed in #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you override ajaxSettings and change the method/type, it was getting ignored in _ajax(). This uses the ajaxSettings method rather than the one passed in, giving users the ability to talk to non-traditional APIs.
You can specify a callback on success/error in your ajaxSettings so you
can do something like:
var mySuccess = function(data, status, jqXHR) {
console.log("success");
}
var myError = function(jqXHR, status, error) {
console.warn("error");
}
var ajaxSettings = function(url, method) {
return {
url: url,
type: method,
successCallback: mySuccess,
errorCallback: myError
};
}
If your API is a bit goofy you can override the ajaxSettings in your
RESTAdapter so you can do things like:
--> POST URL-Encoded, receive JSON back:
myModel.adapter = RESTAdapter.extend({
ajaxSettings: function(url) {
type: "POST",
contentType: "application/x-www-form-urlencoded",
dataType: "json"
// ... snip other properties
}
});
--> PUT JSON encoded content, receive text back
myModel.adapter = RESTAdapter.extend({
ajaxSettings: function(url) {
type: "PUT",
contentType: "json",
dataType: "text"
// ... snip other properties
}
});
This was causing previously working calls to fail because now our ajax calls have the Content-Type: header being added, making the server return a 400 Bad Request error.
# Conflicts: # ember-model.js # packages/ember-model/lib/attr.js # packages/ember-model/lib/belongs_to.js # packages/ember-model/lib/has_many.js # packages/ember-model/lib/rest_adapter.js
added 2 commits
November 19, 2015 22:53
# Conflicts: # ember-model.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you override ajaxSettings and change the method/type, it was
getting ignored in _ajax(). This uses the ajaxSettings method rather
than the one passed in, giving users the ability to talk to
non-traditional APIs.