Remove FIXME comments in STATs. No worth fixing for Quake 3 vanilla, breaks demo and pseudo-netcode#71
Open
LegendaryGuard wants to merge 1 commit intoec-:masterfrom
Conversation
…breaks demo and pseudo-netcode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ensiform is right: https://github.com/ec-/baseq3a/pull/69#issuecomment-3969572775
No matter how many times that effort is made, anyway, breaks demo and pseudo-netcode for Q3 vanilla.
That has already been tested: https://github.com/ec-/baseq3a/pull/69#issuecomment-4138494290
But for modders of other games, it's interesting replace/save this STAT slot in their own mods. To do it, just look at that commit I made previously: a0702c2
If you agree with the PR, do it. Otherwise, feel free to close it.
I don't care if that doesn't merge. But it might be recommended for anyone to not try to fix that and avoid losing time on it.