Feature/submodule tridap - #99
Merged
akoerner1 merged 6 commits intoJul 30, 2026
Merged
Conversation
Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
akoerner1
self-requested a review
July 29, 2026 08:10
Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
Contributor
Author
|
Thanks for merging the PR for adore_map! I now updated the hashes of adore_map (and also of adore_tridap, in order to include a respective minor update). |
Contributor
|
@s0nofab1t Thanks for your contribution! Can you add https://github.com/s0nofab1t/adore_tridap to the THIRD-PARTY.md? |
Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
Contributor
Author
|
Done 😃 |
akoerner1
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added new submodule adore-tridap. This submodule will bundle all modules providing access to (REST) interfaces of TRIDAP. For now, it comprises of a module for map downloading (used in adore_map), and a preliminary module for nowcast querying.
Type of Change
Please merge the related PR for adore_map first - that way I can update the hash for adore_map in this PR here.
Checklist
--signoffflag as required by the Eclipse Foundation.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so others can reproduce.
Test Configuration:
Screenshots (if applicable)
Include any relevant screenshots or videos to demonstrate the feature/fix.
Related Issues
PR for adore_map is related - as has been said before, it would be great if you could merge this related PR before merging this PR here.