Skip to content

Events support - #100

Merged
inf17101 merged 10 commits into
mainfrom
98_events_support
Jan 23, 2026
Merged

inf17101 merged 10 commits into
mainfrom
98_events_support

Conversation

@GabyUnalaq

@GabyUnalaq GabyUnalaq commented Sep 26, 2025 •

Copy link
Copy Markdown
Contributor

Issues: #98

Definition of Done

The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.

@GabyUnalaq GabyUnalaq self-assigned this Sep 26, 2025
@GabyUnalaq GabyUnalaq added the ready for review Waiting for a response from contributor label Sep 26, 2025
@GabyUnalaq GabyUnalaq linked an issue Sep 26, 2025 that may be closed by this pull request
@GabyUnalaq GabyUnalaq added this to the v0.8 milestone Oct 24, 2025
@GabyUnalaq GabyUnalaq mentioned this pull request Jan 16, 2026
1 task done

@inf17101 inf17101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

Comment thread ankaios_sdk/_components/request.py Outdated
Comment thread ankaios_sdk/_components/request.py Outdated
Comment thread ankaios_sdk/_components/response.py Outdated
Comment thread ankaios_sdk/_components/response.py Outdated
Comment thread ankaios_sdk/_components/response.py Outdated
Comment thread ankaios_sdk/_components/event_campaign.py Outdated
Comment thread ankaios_sdk/ankaios.py Outdated
Comment thread tests/response/test_response.py Outdated
Comment thread tests/response/test_response.py Outdated
Comment thread tests/response/test_response.py

@inf17101 inf17101 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
When the event feature is merged to main on Ankaios core, then we can merge this if the pipeline passes afterwards.

@GabyUnalaq

Copy link
Copy Markdown
Contributor Author

I've added a way to fetch the proto files from a branch, added it directly in the setup of the SDK.

@inf17101 can you review this last part as well? In order to use it to this events branch, you must do the following:

  • delete the current folder that has the proto files (in this case it should be ankaios_sdk/_protos/0.8.0-pre
  • Install the SDK with an additional env var: ANKAIOS_PROTO_BRANCH=feature/450_event-support python3 -m pip install .

This should hopefully solve the problem with the protos fetching (#85). The pipeline should still fail (as expected).

@inf17101

inf17101 commented Jan 21, 2026 •

Copy link
Copy Markdown
Contributor

I've added a way to fetch the proto files from a branch, added it directly in the setup of the SDK.

@inf17101 can you review this last part as well? In order to use it to this events branch, you must do the following:

  • delete the current folder that has the proto files (in this case it should be ankaios_sdk/_protos/0.8.0-pre
  • Install the SDK with an additional env var: ANKAIOS_PROTO_BRANCH=feature/450_event-support python3 -m pip install .

This should hopefully solve the problem with the protos fetching (#85). The pipeline should still fail (as expected).

Worked smoothly, thank you! I tested the state event example again after fetching the stuff with your commands above.

@inf17101
inf17101 merged commit c264af7 into main Jan 23, 2026
26 of 41 checks passed
@inf17101
inf17101 deleted the 98_events_support branch January 23, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Waiting for a response from contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Events support

2 participants