Fix sonar maintainability issues - #142
Open
GabyUnalaq wants to merge 4 commits into
Open
GabyUnalaq wants to merge 4 commits into
GabyUnalaq wants to merge 4 commits into
Conversation
|
inf17101
reviewed
Oct 1, 2026
| workload.update_deny_rules( | ||
| [AccessRightRule.state_rule("Invalid", ["mask"])] | ||
| ) | ||
| # with pytest.raises(WorkloadFieldException): |
Contributor
Author
There was a problem hiding this comment.
This was commented out during the fixing of the issues. I uncommented and fixed the test.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There have been some issues discovered by SonarQube. This PR fixes them.
Sonar issues link: https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=eclipse-ankaios_ank-sdk-python
Definition of Done
The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.