-
Notifications
You must be signed in to change notification settings - Fork 30
Feat: Setting Hardware/Software Breakpoint Types via Editor #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asimgunes
wants to merge
2
commits into
eclipse-cdt-cloud:main
Choose a base branch
from
asimgunes:feat/breakpoint-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+148
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /********************************************************************* | ||
| * Copyright (c) 2026 Renesas Electronics Corporation and others | ||
| * | ||
| * This program and the accompanying materials are made | ||
| * available under the terms of the Eclipse Public License 2.0 | ||
| * which is available at https://www.eclipse.org/legal/epl-2.0/ | ||
| * | ||
| * SPDX-License-Identifier: EPL-2.0 | ||
| *********************************************************************/ | ||
| import { | ||
| ExtensionContext, | ||
| Position, | ||
| Location, | ||
| SourceBreakpoint, | ||
| commands, | ||
| debug, | ||
| window, | ||
| Uri, | ||
| } from 'vscode'; | ||
| import { arePathsEqual } from './utils'; | ||
|
|
||
| export class BreakpointModesController { | ||
| constructor(private context: ExtensionContext) {} | ||
|
|
||
| setBreakpointHandler = | ||
| (mode: 'hardware' | 'software') => | ||
| async (values: { uri: Uri; lineNumber: number }) => { | ||
| try { | ||
| const line = values.lineNumber - 1; | ||
|
jreineckearm marked this conversation as resolved.
|
||
| const existingBreakpoints = debug.breakpoints.filter( | ||
| (bp: Partial<SourceBreakpoint>) => | ||
| arePathsEqual( | ||
| bp?.location?.uri?.path, | ||
| values.uri.path, | ||
| ) && bp?.location?.range?.start?.line === line, | ||
| ); | ||
| if (existingBreakpoints.length) { | ||
| const existingBreakpointHasDesiredMode = | ||
| existingBreakpoints.findIndex( | ||
| (bp: any) => bp.mode === mode, | ||
| ) > -1; | ||
| if (existingBreakpointHasDesiredMode) { | ||
| return; | ||
| } | ||
| debug.removeBreakpoints(existingBreakpoints); | ||
| } | ||
| const sp = new SourceBreakpoint( | ||
| new Location(values.uri, new Position(line, 0)), | ||
| ); | ||
| // Limitation of VSCode: https://github.com/microsoft/vscode/issues/304764 | ||
| // This is a workaround to inject 'mode' into VS breakpoint object. | ||
| // This injection functionally working as expected and passes the information | ||
| // correctly through DAP messages, however the breakpoint mode information is not | ||
| // visible in the breakpoint list window in VSCode | ||
| (sp as any).mode = mode; | ||
| debug.addBreakpoints([sp]); | ||
| } catch (e) { | ||
| window.showErrorMessage( | ||
| `Failed to set ${mode} breakpoint: ${e}`, | ||
| ); | ||
| } | ||
| }; | ||
|
|
||
| registerCommands = () => { | ||
| this.context.subscriptions.push( | ||
| commands.registerCommand( | ||
| 'cdt.debug.breakpoints.addHardwareBreakpoint', | ||
| this.setBreakpointHandler('hardware'), | ||
| ), | ||
| ); | ||
| this.context.subscriptions.push( | ||
| commands.registerCommand( | ||
| 'cdt.debug.breakpoints.addSoftwareBreakpoint', | ||
| this.setBreakpointHandler('software'), | ||
| ), | ||
| ); | ||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /********************************************************************* | ||
| * Copyright (c) 2026 Renesas Electronics Corporation and others | ||
| * | ||
| * This program and the accompanying materials are made | ||
| * available under the terms of the Eclipse Public License 2.0 | ||
| * which is available at https://www.eclipse.org/legal/epl-2.0/ | ||
| * | ||
| * SPDX-License-Identifier: EPL-2.0 | ||
| *********************************************************************/ | ||
| import { platform } from 'node:os'; | ||
| import { normalize } from 'node:path'; | ||
|
|
||
| /** | ||
| * This function compares the given paths, returns true if they are equal. | ||
| * | ||
| * - The compare function normalises the paths before checking, which means '.' and '..' expressions | ||
| * reduced properly. | ||
| * - For Windows, the compare function is case insensitive | ||
| * - For Windows, the compare function also handles backslashes, forward slashes insensitively. | ||
| * - Compare function handles undefined values, which means given paths can be undefined. No need to check | ||
| * undefined before sending the arguments. | ||
| * | ||
| * @param path1 | ||
| * First path to compare | ||
| * @param path2 | ||
| * Second path to compare | ||
| */ | ||
| export const arePathsEqual = ( | ||
| path1: string | undefined, | ||
| path2: string | undefined, | ||
| ): boolean => { | ||
| if (!path1 || !path2) { | ||
| return path1 === path2; | ||
| } | ||
| const nPath1 = normalize(path1); | ||
| const nPath2 = normalize(path2); | ||
| return platform() === 'win32' | ||
| ? nPath1.localeCompare(nPath2, undefined, { sensitivity: 'accent' }) === | ||
| 0 | ||
| : nPath1 === nPath2; | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.