feat(workspace-details): add Change Editor to workspace Overview tab by olexii4 · Pull Request #1663 · eclipse-che/che-dashboard

olexii4 · 2026-09-03T23:34:14Z

What does this PR do?

Adds a Change Editor form group to the Workspace Details → Overview tab, following the same UX pattern as "Change AI Tools".

When a workspace is stopped, a pencil button opens a modal with radio buttons listing all available editors (grouped by display name). Each editor group with multiple versions shows an inline version picker (EllipsisV dropdown), matching the existing EditorSelector gallery in Create Workspace. On confirm, the dashboard:

Creates a new DevWorkspaceTemplate for the selected editor (reusing DevWorkspaceClient.createDevWorkspaceTemplate, which sets ownerReferences and injects cluster env vars).
Patches the workspace — updates che.eclipse.org/che-editor, the devfile-source factory params, and spec.contributions[0].kubernetes.name in one atomic PATCH.
Deletes the old DevWorkspaceTemplate (the backend DELETE route already existed; a deleteTemplate frontend wrapper is added to devWorkspaceTemplateApi.ts).

The button is disabled when the workspace is not STOPPED or FAILED, using the same isReadonly guard already in place for Name, Storage Type, and AI Tool.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23935

Is it tested? How?

Deploy Eclipse Che with the dashboard image from this PR.
Create a workspace (any sample, any editor).
Stop the workspace, then navigate to Workspace Details → Overview.
Verify the Editor row shows the current editor name and version with a pencil icon.
Click the pencil — the Change Editor modal opens with radio buttons for each available editor and an EllipsisV version picker for editors with multiple versions.
Select a different editor, optionally pick a non-default version, and click Save.
Verify the Overview tab updates to show the new editor.
Start the workspace — confirm it opens in the newly selected editor.

Without this PR: no way to change the editor on an existing stopped workspace without recreating it.

Release Notes

Added "Change Editor" option to the workspace Overview tab, allowing users to switch the IDE of a stopped workspace without recreating it.

Docs PR

N/A

openshift-ci · 2026-09-03T23:34:21Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

che-bot · 2026-09-03T23:34:23Z

Click here to review and test in web IDE:

github-actions · 2026-09-03T23:49:54Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

codecov · 2026-09-04T01:39:08Z

Codecov Report

❌ Patch coverage is 93.54839% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.46%. Comparing base (c38b9fc) to head (a320a72).

Files with missing lines	Patch %	Lines
...kspaceDetails/OverviewTab/Editor/SelectorModal.tsx	96.08%	9 Missing ⚠️
...services/backend-client/devWorkspaceTemplateApi.ts	18.18%	9 Missing ⚠️
...es/actions/actionCreators/changeWorkspaceEditor.ts	93.70%	9 Missing ⚠️
.../dashboard-frontend/src/services/helpers/editor.ts	90.47%	3 Missing and 1 partial ⚠️
...ages/WorkspaceDetails/OverviewTab/Editor/index.tsx	96.96%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #1663    +/-   ##
========================================
  Coverage   92.45%   92.46%            
========================================
  Files         609      612     +3     
  Lines       63850    64377   +527     
  Branches     5011     5058    +47     
========================================
+ Hits        59031    59524   +493     
- Misses       4754     4786    +32     
- Partials       65       67     +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-09-04T13:50:39Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

github-actions · 2026-09-04T13:57:18Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

github-actions · 2026-09-04T14:21:41Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

Creates new DevWorkspaceTemplate, patches workspace annotations and spec.contributions, then deletes the old template. Reuses createDevWorkspaceTemplate and patchWorkspace from existing code. Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

Assisted-by: Claude Haiku 4.5 Signed-off-by: Oleksii Orel <oorel@redhat.com>

Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

The DELETE /namespace/:ns/devworkspacetemplates/:name route was wrapped in isLocalRun(), making it unavailable in production deployments. The changeWorkspaceEditor action creator calls deleteTemplate() after switching the editor, so the orphaned old template was never cleaned up on a real cluster. Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

- Overview tab: remove version from editor label; hide pencil button (not just disable) when workspace is not stopped/failed; add tooltip icon (Popover + FormGroupLabelHelp) matching AI Tool row alignment - Change Editor modal: fixed header (title + filter) does not scroll with the list; filter now searches display name, all versions, and all descriptions; filter placeholder shortened to "Filter by"; filter input capped at max-width 30%; version labels shown on all rows, not just the selected one; checkbox style (type=checkbox) instead of radio; versionLabel style matches AI Tool (height, margin-left, no min-width); custom editor shown as informational item when current editor ID is unknown to the registry - After confirming an editor change, show "Workspace has been updated" success alert or a danger alert with the error message, matching the AI Tool behaviour (uses AppAlerts via lazyInject) Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

- devWorkspaceTemplateApi: add deleteTemplate success + error tests - changeWorkspaceEditor: add error-path and same-name-skip tests - editor helpers: add displayName/name fallback tests - SelectorModal: add filter-reset-on-close test - EditorFormGroup: add architecture-filter test Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

github-actions · 2026-09-04T15:24:01Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

github-actions · 2026-09-04T15:28:56Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

openshift-ci · 2026-09-04T16:45:06Z

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v19-dashboard-happy-path	`2b372ae`	link	true	`/test v19-dashboard-happy-path`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

olexii4 requested review from akurinnoy and ibuziuk as code owners September 3, 2026 23:34

olexii4 added 10 commits September 4, 2026 18:10

feat(editor): add grouping and annotation helpers

a82a3a4

Assisted-by: Claude Haiku 4.5 Signed-off-by: Oleksii Orel <oorel@redhat.com>

feat(workspace-details): add EditorSelectorModal

7f4bc01

Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

feat(workspace-details): add EditorFormGroup to Overview tab

e7bf22c

Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

feat(workspace-details): wire EditorFormGroup into Overview tab

19cb3b5

Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

fix(workspace-details): rename filter aria-label to "Filter editors by"

133683f

Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

fix(workspace-details): adjust Overview tab readonly/editable alignment

b0a131f

Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 force-pushed the che-23935 branch from 3cebf99 to 2b372ae Compare September 4, 2026 15:14

olexii4 mentioned this pull request Sep 4, 2026

[Dashboard] Ide Switch eclipse-che/che#23935

Open

Navigation Menu

Uh oh!

feat(workspace-details): add Change Editor to workspace Overview tab - #1663

feat(workspace-details): add Change Editor to workspace Overview tab#1663
olexii4 wants to merge 10 commits into
mainfrom
che-23935

olexii4 commented Sep 3, 2026 •

edited

Loading

Uh oh!

openshift-ci Bot commented Sep 3, 2026

Uh oh!

che-bot commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

codecov Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

openshift-ci Bot commented Sep 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

olexii4 commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Is it tested? How?

Release Notes

Docs PR

Uh oh!

openshift-ci Bot commented Sep 3, 2026

Uh oh!

che-bot commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

codecov Bot commented Sep 4, 2026

Codecov Report

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

openshift-ci Bot commented Sep 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

olexii4 commented Sep 3, 2026 •

edited

Loading