avoid emitting a phantom byte on truncated input in QPDecoderStream#207
Open
arib06 wants to merge 1 commit into
Open
avoid emitting a phantom byte on truncated input in QPDecoderStream#207arib06 wants to merge 1 commit into
arib06 wants to merge 1 commit into
Conversation
Signed-off-by: mohammed arib <arib@bugqore.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QPDecoderStream.read casts the result of in.read() straight to a byte, so when an '=' is followed by a single hex digit (or a bare CR) at end of stream, the -1 becomes 0xFF and gets pushed back and later returned as a decoded byte that was never in the input. Quoted-printable bodies are untrusted MIME content, so a truncated encoded atom silently injects a 0xFF into the decoded output. This guards both the = and = reads for -1 so the real trailing bytes pass through unchanged, and adds a QPDecoderStreamTest covering the truncated cases.