Handle referencing schemas through UNC paths#1782
Merged
angelozerr merged 1 commit intoJun 5, 2026
Merged
Conversation
- When downloading external resources is disabled, don't attempt
to download non-local schema files referenced using UNCs
- Use the schema cache for resources referenced through UNCs
- eg. `file://example.org/schemas/my-schema.xsd`,
`//example.org/schemas/my-schema.xsd`,
`file:////example.org/schemas/my-schema.xsd`
- Unless the authority is `localhost` eg.
`//localhost/C$/Users/Mira/my-schema.xsd`
- Fix a minor bug where the error range is wrong for schemas referenced through
a UNC starting with `//` in `<?xml-model href="...`
Signed-off-by: David Thompson <davidethompson@me.com>
datho7561
force-pushed
the
handle-schemas-accessed-through-unc
branch
from
e4145d9 to
97d3841
Compare
Contributor
|
LGTM thanks @datho7561 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file://example.org/schemas/my-schema.xsd,//example.org/schemas/my-schema.xsd,file:////example.org/schemas/my-schema.xsdlocalhosteg.//localhost/C$/Users/Mira/my-schema.xsd//in<?xml-model href="...