feat: render Github Markdown Tables in the text hover #1488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 68f9534 added the necessary plugin for support for Github Markdown Tables but this library was not properly wired up. This commit correctly wires Github Markdown Tables support.
Comment on lines
-114
to
+119
| Parser parser = Parser.builder().build(); | ||
| List<Extension> extensions = List.of(TablesExtension.create()); | ||
| Parser parser = Parser.builder().extensions(extensions).build(); | ||
| Node document = parser.parse(result); | ||
| HtmlRenderer renderer = HtmlRenderer.builder().build(); | ||
| HtmlRenderer renderer = HtmlRenderer.builder().extensions(extensions).build(); |
Contributor
There was a problem hiding this comment.
The JavaDoc of Parser indicates that the instances is thread-safe. commonmark/commonmark-java#83 seems to indicate that HtmlRendere is also thread-safe
Can we create singleton instances of the classes instead and re-use them?
I think it would also makes sense to make this rendering code into a utility method so we can write a small unit test, which makes sure that Table-Rendering still works.
Contributor
Author
There was a problem hiding this comment.
Thanks for the comment. Yes, that makes sense, I will do that if I have some extra time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 68f9534 added the necessary plugin for support for Github Markdown Tables but this library was not properly wired up. This commit correctly wires Github Markdown Tables support.